Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #513 - not using site.title for title in some pages as the title either becomes too long or wrong if variable is not set correctly #514

Closed
wants to merge 2 commits into from

Conversation

anenadic
Copy link
Contributor

For for #513. Removed the use of site.title variable from the title of some pages. Kept the variable in _config.yml if it used by something else.

@anenadic anenadic changed the title Fix for #513 Fix for #513 - not using site.title for title in some pages as it is either too long or wrong if variable is not set correctly Jul 17, 2018
@anenadic anenadic changed the title Fix for #513 - not using site.title for title in some pages as it is either too long or wrong if variable is not set correctly Fix for #513 - not using site.title for title in some pages as the title either becomes too long or wrong if variable is not set correctly Jul 17, 2018
@rgaiacs
Copy link
Contributor

rgaiacs commented Jul 17, 2018

The changes proposed here should go to https://github.com/carpentries/styles.

@anenadic
Copy link
Contributor Author

Ah, OK, good to know.

@fmichonneau
Copy link
Contributor

Thanks @anenadic that was fixed in our template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants